Fix definitions with multiple clauses and optional values that only have 1 param

Just following the suggestion in the warning, maybe:

def init(opts \\ [])
def init(%State{} = state), do: {:ok, state, 1_000}
def init(opts) do
  state = struct(State, opts)
  {:ok, state, 1_000}
end

This is confusing to me. By doing it that way, I am saying that state is actually an opts, right ?

The problem is that it’s elixir creating multiple function heads for you here:

def init(), do: init([])
def init(%State{} = state), do: …
def init(opts), do: …

So it doesn’t really care about your patter match at all. It just needs to know that the first parameter is optional and shall be passed [] if not present. You could do:

def init(state_or_opts \\ [])
def init(%State{} = state), do: {:ok, state, 1_000}
def init(opts) do
  state = struct(State, opts)
  {:ok, state, 1_000}
end

Looking at your code, for me it seems much more like opts beeing a listified %State{}…