tjchambers

tjchambers

Erlang. OTP-28
Elixir 1.20.0-rc.3 (9b80ab5) (compiled with Erlang/OTP 28)

In rc.3 I am getting a new type checking warning for functions I have guards on lists to ensure the list contains terms of the proper type.

Example:

def filter(tags, value)
      when is_list(tags) and is_struct(hd(tags)) and is_binary(value) do
    converted_value = to_regex(value)
Enum.filter(tags, fn tag -> tag.tag =~ ~r|^#{converted_value}|i end)
end
  warning: incompatible types given to Kernel.is_map_key/2:

        is_map_key(hd(tags), :__struct__)

    given types:

        term(), :__struct__

    but expected one of:

        #1
        %{..., __struct__: term()}, term()

        #2
        %{..., __struct__: not_set()}, term()

    where "tags" was given the types:

        # type: empty_list() or non_empty_list(term(), term())
        # from: lib/sct/joe/services/tag_matcher.ex:27:12
        is_list(tags)

        # type: non_empty_list(term(), term())
        # from: lib/sct/joe/services/tag_matcher.ex:27:40
        hd(tags)

    type warning found at:
    │
 27 │       when is_list(tags) and is_struct(hd(tags)) and is_binary(value) do

My guard for tags is attempting to ensure that the tags are a list, and that list is non-empty and that it contains structs. I have not specified that type of the structure since there are a number of compatible structs that this function serves.

I do not quite understand why this should result in a type check warning. Any guidance would be useful. I have dozens of similarly constructed function guards which are all emitting this type of warning.

Showing Posts 1 to 4

mudasobwa

mudasobwa

Creator of Cure

I am not sure, why this results in a type error, but I would definitely write it differently (andalso more precisely):

def filter([%s{} | _] = tags, value)
      when s in [Foo, Bar, Baz] and is_binary(value)
tjchambers

tjchambers OP

I do like that better. Thank you! Still begs the question about the type error.

josevalim

josevalim

Creator of Elixir

It is a bug. Can you please file a report? Thank you!

tjchambers

tjchambers OP

will do.

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
ryanwinchester
apply_graft/2 doesn’t rewrite an add_many sub-workflow’s deps on an add step. Grafted jobs cancel with “upstream job was deleted” Version...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews