tjchambers

tjchambers

Static Type Checking on guards

Erlang. OTP-28
Elixir 1.20.0-rc.3 (9b80ab5) (compiled with Erlang/OTP 28)

In rc.3 I am getting a new type checking warning for functions I have guards on lists to ensure the list contains terms of the proper type.

Example:

def filter(tags, value)
      when is_list(tags) and is_struct(hd(tags)) and is_binary(value) do
    converted_value = to_regex(value)
Enum.filter(tags, fn tag -> tag.tag =~ ~r|^#{converted_value}|i end)
end
  warning: incompatible types given to Kernel.is_map_key/2:

        is_map_key(hd(tags), :__struct__)

    given types:

        term(), :__struct__

    but expected one of:

        #1
        %{..., __struct__: term()}, term()

        #2
        %{..., __struct__: not_set()}, term()

    where "tags" was given the types:

        # type: empty_list() or non_empty_list(term(), term())
        # from: lib/sct/joe/services/tag_matcher.ex:27:12
        is_list(tags)

        # type: non_empty_list(term(), term())
        # from: lib/sct/joe/services/tag_matcher.ex:27:40
        hd(tags)

    type warning found at:
    │
 27 │       when is_list(tags) and is_struct(hd(tags)) and is_binary(value) do

My guard for tags is attempting to ensure that the tags are a list, and that list is non-empty and that it contains structs. I have not specified that type of the structure since there are a number of compatible structs that this function serves.

I do not quite understand why this should result in a type check warning. Any guidance would be useful. I have dozens of similarly constructed function guards which are all emitting this type of warning.

Most Liked

mudasobwa

mudasobwa

Creator of Cure

I am not sure, why this results in a type error, but I would definitely write it differently (andalso more precisely):

def filter([%s{} | _] = tags, value)
      when s in [Foo, Bar, Baz] and is_binary(value)
josevalim

josevalim

Creator of Elixir

It is a bug. Can you please file a report? Thank you!

tjchambers

tjchambers

will do.

Where Next?

Popular in Questions Top

nobody
Hi! In PHP: $_SERVER[‘SERVER_ADDR’] - in Elixir? Searched the docs for ip address and the web, no good results. Thanks!
New
JeremM34
Hello, how can I check the Phoenix version ? Thanks !
New
baxterw3b
Hi guys, i’m new in the Elixir world, and i have to say, that i love it! i’m having some problem to understand anonymous functions with ...
New
aadeshere1
I have a another noob question about loop. Since elixir is immutable, while loop is not directly possible. total = 10 while total != 0 ...
New
alice
Hey, Just curious what are the main benefits of Elixir compared to Clojure? When is Elixir more useful than Clojure and vice versa? Th...
New
fayddelight
I tried installing elixir 1.11.2 erlang 23.3.4 via asdf in my zsh shell. Enabled the versions locally and globally. When I list them ...
New
JorisKok
I have a server on AWS, and was running a load test using artillery. When looking at the Phoenix dashboard I see the Ports going to 100% ...
New

Other popular topics Top

vonH
In asking this question I am more interested about the expressiveness of the language itself and less concerned about the availability of...
New
greenz1
I have a phoenix application from which a user can download multiple(5-6) files of size 1MB. I couldn’t find anything related to sending ...
New
sen
Hi All, I set a environment variables in dev.exs , like below code. when i start server, how can i set the ${enable} value? thanks. d...
New
Patoshizzle
After calling mix ecto.create I get this error: 17:00:32.162 [error] GenServer #PID<0.412.0> terminating ** (Postgrex.Error) FATAL...
New
sergio
Kind of like when jquery came out, it was super necessary. Existing drag and drop libraries have a bunch of baggage to support old browse...
New
jason.o
In the code below, if the create action is not set to accept “extra_key” as an input, it errors out with a message shown above. Is there ...
New

We're in Beta

About us Mission Statement