boblancer

boblancer

Hi
Wanted opinion about what would be the best practice to enforce auto formatting in CI pipeline

I was thinking that I could run mix format and commit it repo before merge

Showing Posts 1 to 3

lucaong

lucaong

One simple way is to run mix format --check-formatted as a check on the CI pipeline, so that it would fail if the code is not properly formatted. Here you can see an example with GitHub Action on my CubDB project. The action is run for every pull request as part of the build.

I often include the same check as a pre-push Git hook, so I get informed of format issues even before I push my code.

Note that this won’t fix the format issues, but rather just inform about them and cause the pipeline to fail. It is also possible to auto-fix the format and push a new commit, but I normally prefer not to, as it opens up possible issues with concurrent pipelines.

Sebb

Sebb

I do the checks in a pre-commit hook

#!/bin/sh

mix format --check-formatted
if [ $? -ne 0 ]; then exit 1; fi

mix credo --strict > /dev/null
if [ $? -ne 0 ]; then mix credo --strict; exit 1; fi

mix dialyzer > /dev/null
if [ $? -ne 0 ]; then mix dialyzer; exit 1; fi

mix test --warnings-as-errors > /dev/null
if [ $? -ne 0 ]; then mix test --warnings-as-errors; exit 1; fi
kwando

kwando

I don’t want CI to “rewrite” my code, but I’m all for a mix format --check-formatted step in CI :slight_smile:

— All posts loaded —

Where Next? Top

Trending in Discussions Top

AstonJ
As the title says, please share what you’ve been up to with Elixir. Whether that’s been learning it, looking into it, making stuff with i...
2977 94592 917
New
cblavier
Hey there, It’s been more than a year since we started using LiveView as our main UI library and building a whole library of UI componen...
New
mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
heathen
Quite interesting article Google brought me. Didn’t find any mentions about it here. What do you think in general? Would you use togethe...
New
mhanberg
Hi everyone! The first release candidate for the Expert language server project is now available! We’ve published a press release detai...
New
AstonJ
Since we have deprecated our Erlang sections (as we have dedicated Erlang Forums now) let’s add this thread for those who’d like to post ...
New
maennchen
:warning: Security advisory: Decimal DoS vulnerability A vulnerability has been published for decimal where very large exponents can cau...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
webofbits
With AI doing more of the implementation work, I’ve been wondering how much coding I should deliberately keep doing myself. My main conc...
#ai
New

Latest on Elixir Forum

Elixir Forum

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews