przemyxe0p

przemyxe0p

Hi,
I am wondering why my solution wil not work

1. source: Perfect Numbers in Elixir on Exercism

2. solution attempt:

  @spec classify(number :: integer) :: {:ok, atom} | {:error, String.t()}
  def classify(number) do
    case aliquot_sum(number) do
      number -> ok(:perfect)
      x when x > number -> ok(:abundant)
      x when x < number -> ok(:deficient)
    end
  end

  defp ok(item), do: {:ok, item}
  defp aliquot_sum(number), do: get_divisors(number) |> Enum.sum()

  defp get_divisors(number, divisor \\ 1, acc \\ [])
  defp get_divisors(number, divisor, acc) when divisor > div(number,2), do: acc
  defp get_divisors(number, divisor, acc) when rem(number, divisor) == 0,
    do: get_divisors(number, divisor + 1, [divisor | acc])
  defp get_divisors(number, divisor, acc), do: get_divisors(number, divisor + 1, acc)
end

3. question:

Complier is saying:

this clause cannot match because a previous clause at line 15
always matchesElixir
perfect_numbers.ex(15, 7): related

and

variable "number" is unused (there is a variable with the same name in the
context, use the pin operator (^) to match on it or prefix this variable 
with underscore if it is not meant to be used)Elixir

Why is that, why it cannot match with number passed to function?

Showing Posts 13 to 4

al2o3cr

al2o3cr

This form rebinds the name number inside the case branch:

def some_fun(number) do
  case 2*number do
    number ->
      # number here is bound to a new value, shadowing the argument named number

This will match ANY integer passed to some_fun.

ON THE OTHER HAND

Using the pin operator says “match this existing value”:

def some_fun(number) do
  case 2*number do
    ^number ->
      # number here is still bound to the argument

That will only match if some_fun is passed 0, since 2*0 == 0

sodapopcan

sodapopcan

Oh sorry wasn’t responding specifically to your question.

But to answer it: Elixir allows variable re-binding, ie, you can say: number = number+ 1 and not get an error that number is already defined. Like =, -> is also a binding operator, so when you say number -> ok(:perfect), number is rebound. The match on the value of number, you need to use the pin operator.

przemyxe0p

przemyxe0p OP

Ok, I get it, but the question was, why it was not working with case this, matching why do we have to use this ^ pin operator?

sodapopcan

sodapopcan

People have a weird aversion to cond for some reason that I don’t really understand. Doing pure boolean checks is exactly what it exists for. The case version is essentially the same with unnecessary extra syntax. Using cond gives added information that indeed all clauses are boolean checks. It’s only rare because this doesn’t come up as often in Elixir, but it certainly does come up!

przemyxe0p

przemyxe0p OP

Last question, i cannot find explanatio why this works that way. Do you have explanation or link to resources?

krasenyp

krasenyp

In my experience it’s very rare to use cond but it’s still valid.

kokolegorille

kokolegorille

Because it’s very rare to use ^number in the case :slight_smile:

Yet, You can do as You like

przemyxe0p

przemyxe0p OP

After adding ^ operator it’s right why should I use cond? What is more “idiomatic” whatever this “idiomatic” word mean? :smiley:

kokolegorille

kokolegorille

No, your logic is wrong and number might not be what You think…

As soon as there is a match, the rest of the case is discarded

the number in the case is not the number parameter, it is a new number

You probably should write this with cond

aliquot = aliquot_sum(number)
cond do
  aliquot > number -> ...
  aliquot < number -> ...
  aliquot == number -> ...
end

Where Next? Top

Trending in Questions Top

katta
I having some trouble figuring out if I have set myself too strict of standards for my production server. Currently I can handle 75% of r...
New
achenet
Hello, I’m trying to build a basic Phoenix web-app, and I’d like to use Tailwind. However, when I launch mix phx.server, I get an error...
New
kpanic
Hi everyone, I am toying with the idea of building a “match maker” for giving personal help to people that wants to start coding. I sta...
New
Cxx-mlr
I’m working on a small exercise involving update_in/3, and I came up with this solution: data = %{ name: "Periodic Table", category:...
New
ChrisAmelia
I’ve got trouble wrapping my head around the order in which functions are called in this snippet (from Phoenix’s authentication): toke...
New
dillonoconnor
Is there any way to avoid the Hologram compiler running when using iex? It seems like the front-end code could potentially be disregarded...
New
thiagogsr
** (ArgumentError) expected :max_attempts to be a positive integer, got: {:@, [line: 10, column: 19], [{:max_attempts, [line: 10, column:...
New

Other Trending Topics Top

GenericJam
Edit: 2026 May 15 - This post is archived. Mob is alive!! Main docs: mob v0.7.11 — Documentation A bit of explanation for the slightly c...
New
mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
budgie
A little off-topic, but I feel like people here have a good head on their shoulders. I used to be quite good at making software. Was luc...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
mcass19
ExRatatui lets you cook up rich terminal UIs in Elixir, powered by Rust’s ratatui via Rustler NIFs. Build interactive terminal applicatio...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews