KikisBomb
Bad practice to send requests twice using the same connection in the same test?
A coworker has written a controller test where he occasionally sends a test request twice in one test using the same connection. Here is an example (lines 81 and 84):
This was not previously a problem as the tests had passed. However, I am modifying the router to require JWT authentication, which involves setting the request header at one point. This causes “(Plug.Conn.AlreadySentError) the response was already sent”. I suspect it has to do with line 84 where the same connection was involved in another request. Is this bad practice? If not, how do I resolve the (Plug.Conn.AlreadySentError)? Thanks
Most Liked
NobbZ
It’s usually fine to reuse the conn, perhaps recycle helps?
If not, I think the big is in your implementation rather than in the tests.
Ps: it’s much easier to read if you actually copy and paste code and annotate it using standard markdown, than to put a screenshot, which is bad for smaller bandwidths or data plans.
blatyo
If I were doing this, I’d probably do:
result_conn = put conn, ...
# do stuff
result_conn = get conn, ...
That way conn is never rebound and is always the fresh conn provided to the test. However, I agree that making two requests in the same test is probably a code smell.
Popular in Questions
Other popular topics
Latest Phoenix Threads
Latest on Elixir Forum
Sponsor Spotlight
Develop your skills with books, videos, and courses.
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #phoenix_html
- #iex
- #blog-post
- #graphql
- #genstage
- #ai
- #websockets
- #supervisor
- #advent-of-code
- #elixirconf-us
- #distillery
- #processes
- #forms
- #api
- #metaprogramming
- #security
- #performance
Our Sponsors
Build Elixir applications with speed and confidence.
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Catch errors, track performance, monitor hosts and more.
Real-time error tracking, performance insights, and observability for devs.
Practical resources that improve the lives of professional developers.
Develop your skills with books, videos, and courses.
Producing high quality Elixir screencasts since 2017.
Courses that'll move you from confusion to "Aha, now I get it!"