rrmartins

rrmartins

Hello,

I came to make a provocation about a way of writing code.

I’m writing a small private project to shorten urls and I came across a change in the writing of a case.

I saw that when writing the case in my function I felt that the function seemed complex to understand and read. I thought about changing the case to use Pattern Matching of the functions.

leaving this code:

defp validate_url(changeset, field, opts \\ []) do
    validate_change(changeset, field, fn _, value ->
      case URI.parse(value) do
        %URI{scheme: nil} ->
          "is missing a scheme (e.g. https)"

        %URI{host: nil} ->
          "is missing a host"

        %URI{host: host} ->
          case :inet.gethostbyname(Kernel.to_charlist(host)) do
            {:ok, _} -> nil
            {:error, _} -> "invalid host"
          end
      end
      |> case do
        error when is_binary(error) -> [{field, Keyword.get(opts, :message, error)}]
        _ -> []
      end
    end)
  end

for this:

  defp validate_url(changeset, field, opts \\ []) do
    validate_change(changeset, field, fn _, value ->
      value
      |> URI.parse()
      |> handle_parse()
      |> handle_error_parse()
    end)
  end

  defp handle_error_parse(error) when is_binary(error), do: [{field, Keyword.get(opts, :message, error)}]
  defp handle_error_parse(_), do: []

  defp handle_parse(%URI{scheme: nil}), do: "is missing a scheme (e.g. https)"
  defp handle_parse(%URI{host: nil}), do: "is missing a host"

  defp handle_parse(%URI{host: host}) do
    host
    |> Kernel.to_charlist()
    |> :inet.gethostbyname()
    |> handle_hostbyname()
  end

  defp handle_hostbyname({:ok, _}), do: nil
  defp handle_hostbyname({:error, _}), do: "invalid host"

I’m preferring to use Pattern Matching instead of case and other control flow structures.

what do you think?

Most Liked

stefanchrobot

stefanchrobot

I personally prefer case over multiple function heads (sidenote: both use pattern matching!). But I’d do this:

defp validate_url_field(changeset, field, opts \\ []) do
  validate_change(changeset, field, fn _, value ->
    case validate_url(value) do
      :ok -> []
      {:error, message} -> [{field, Keyword.get(opts, :message, message)}]
    end
  end)
end

defp validate_url(string) do
  case URI.parse(string) do
    %URI{scheme: nil} ->
      {:error, "is missing a scheme (e.g. https)"}

    %URI{host: nil} ->
      {:error, "is missing a host"}

    %URI{host: host} ->
      case :inet.gethostbyname(Kernel.to_charlist(host)) do
        {:ok, _} -> :ok
        {:error, _} -> {:error, "invalid host"}
      end
  end
end
sodapopcan

sodapopcan

This is one of those cases of “Which do you prefer?” Your answer to that is the right one :smiley:

Personally I prefer multi-head functions whenever it’s possible, but that’s just me. I maybe wouldn’t start every function name with handle_ as it feels a bit noisy but, again, that’s just me.

sodapopcan

sodapopcan

PS, pattern matching essentially is control flow (among other things). It’s right there on the Erlang homepage :slight_smile:

Last Post!

cjbottaro

cjbottaro

I am on the fence on this one. Sometimes I think the code is cleaner looking with a single function head that has a single case statement… :thinking:

Especially if the function has other heads that deal with other things. Sometimes the combinatory explosion flatting is just too much.

Where Next? Top

Trending in Discussions Top

AstonJ
As the title says, please share what you’ve been up to with Elixir. Whether that’s been learning it, looking into it, making stuff with i...
2977 94592 917
New
cblavier
Hey there, It’s been more than a year since we started using LiveView as our main UI library and building a whole library of UI componen...
New
mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
heathen
Quite interesting article Google brought me. Didn’t find any mentions about it here. What do you think in general? Would you use togethe...
New
AstonJ
Since we have deprecated our Erlang sections (as we have dedicated Erlang Forums now) let’s add this thread for those who’d like to post ...
New
maennchen
:warning: Security advisory: Decimal DoS vulnerability A vulnerability has been published for decimal where very large exponents can cau...
New
Null-logic-0
What IDE or editor are you using for Elixir development? Personally, I use Zed, and I really like it, but sometimes I wish there were a ...
New

Other Trending Topics Top

marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
webofbits
With AI doing more of the implementation work, I’ve been wondering how much coding I should deliberately keep doing myself. My main conc...
#ai
New
webofbits
Aludel - LLM Evaluation Workbench Aludel is an embeddable Phoenix LiveView dashboard for evaluating and comparing LLM prompts across mult...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews