Sebb
Exploit "Errors in guards" in defguard
I have this helper function where I exploit the Errors in Guards feature.
def non_empty(val, _msg) when length(val) > 0, do: {:ok, val}
def non_empty(val, _msg) when map_size(val) > 0, do: {:ok, val}
def non_empty(val, _msg) when tuple_size(val) > 0, do: {:ok, val}
def non_empty(_val, msg), do: {:error, msg}
(I can call non_empty({:foo}, "") though length({:foo}) raises)
Is there a way to put this into a defguard - without using is_list/1 etc?
defguard enum_size... ???
Marked As Solved
eksperimental
This is how I would rewrite your clauses into just two.
def non_empty(val, _msg)
when is_list(val) and val != []
when is_map(val) and map_size(val) > 0
when is_tuple(val) and tuple_size(val) > 0 do
{:ok, val}
end
def non_empty(_val, msg), do: {:error, msg}
by checking for the type, it does not raise (anyway that is not a problem if you only have one when clause), but in my example it is needed, othewise later when clauses will never be evaluated if any prior clause raises.
Personally I consider good practice to check for types.
Also Liked
eksperimental
kartheek
size is constant time O(1), where as length is linear time -O(N) - Naming conventions — Elixir v1.20.2
Isn’t non_empty for lists a bit more expensive operation - depending on size of list?
Enum.empty?/1 just compares to when it is list.
def empty?(enumerable) when is_list(enumerable) do
enumerable == []
end
Maybe your non_empty can be changed to this ?
def non_empty(val, _msg) when map_size(val) > 0, do: {:ok, val}
def non_empty(val, _msg) when tuple_size(val) > 0, do: {:ok, val}
def non_empty([], msg), do: {:error, msg}
def non_empty(val, _msg) when is_list(val), do: {:ok, val}
def non_empty(_val, msg), do: {:error, msg}
or something like this only if you pass enumerable or tuple, else this will return {:ok, val} for strings, numbers, etc
def non_empty([], msg), do: {:error, msg}
def non_empty({}, msg), do: {:error, msg}
def non_empty(%{} = val, msg) when map_size(val) == 0, do: {:error, msg}
def non_empty(val, _msg), do: {:ok, val}
eksperimental
please don’t! It totally changes the logic of the function, unless you are fine with it.
As mentioned by @karthheek, it will return {:ok, } in case of an uncovered type.
non_empty(0, "it is empty") will return {:ok, 0}
Popular in Questions
Other popular topics
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #javascript
- #code-sync
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #phoenix_html
- #iex
- #blog-post
- #graphql
- #genstage
- #ai
- #websockets
- #supervisor
- #advent-of-code
- #elixirconf-us
- #distillery
- #processes
- #forms
- #api
- #metaprogramming
- #security
- #performance








