I have this module used to filter Ecto results, the first function gets called 3 times, what modifications are needed to make it get called only once (details in code)?
defmodule MangoWeb.Filters.Borrowers do
import Ecto.Query
use Inquisitor
# I want to run this only once when calling build_query(conn, _params) from the controller
def build_query(query, _attrs, _values, _conn) do
user = _conn.assigns[:current_user]
from b in query,
join: i in assoc(b, :institute),
where: i.id == ^user.institute_id
end
# but the above gets called two additional times because of these two:
def build_query(query, "code", code, _conn) when code != "" do
Ecto.Query.where(query, [p], ilike(p.code, ^"%#{code}%"))
end
def build_query(query, "address", address, _conn) when address != "" do
Ecto.Query.where(query, [p], ilike(p.address, ^"%#{address}%"))
end
end
The thing that I note is that the more specific, or restricted, function calls (the one where you pattern match on “code” or “address”) are declared after your more generic function. It seems that the order of these should be reversed. You should put the more specific clauses of your function first and the more generic ones at the end.
Elixir will pattern match against your functions in the order that they are declared in the source.
It looks like the library you are using (Inquisitor) calls your build_query/4 method once for each attribute passed in. Why do you want build_query/4 to only be called once?
And here’s the function as defined in the library:
defmodule Inquisitor do
defmacro __using__(_opts) do
quote do
def build_query(query, context, params) do
Enum.reduce(params, query, fn({key, value}, query) ->
build_query(query, key, value, context)
end)
end
@before_compile Inquisitor
end
end
defmacro __before_compile__(_env) do
quote do
def build_query(query, _key, _value, _context), do: query
defoverridable [build_query: 4]
end
end
end