jswny
I’m using Programming Phoenix by Chris McCord as a reference to build my personal blog. I’ve replicated the authentication implementation almost exactly, but now that I am working through the chapter about testing the authentication plug, I’m getting (Plug.Conn.AlreadySentError) the response was already sent. However, the site works fine when navigating through it regularly, just not in the tests. I’ve looked the problem up and ensured I don’t have plug :action anywhere and am calling halt() after I redirect when an action isn’t authorized. If anyone could help I’d really appreciate it
Relevant code:
1) test login puts the user into the session (PhoenixBlog.AuthTest)
test/plugs/auth_test.exs:28
** (Plug.Conn.AlreadySentError) the response was already sent
stacktrace:
(plug) lib/plug/conn.ex:862: Plug.Conn.put_session/3
(phoenix_blog) web/plugs/auth.ex:25: PhoenixBlog.Plugs.Auth.login/2
test/plugs/auth_test.exs:31: (test)
2) test authenticate_user halts when no current_user exists (PhoenixBlog.AuthTest)
test/plugs/auth_test.exs:14
** (Plug.Conn.AlreadySentError) the response was already sent
stacktrace:
(plug) lib/plug/conn.ex:607: Plug.Conn.put_resp_header/3
(phoenix) lib/phoenix/controller.ex:303: Phoenix.Controller.redirect/2
(phoenix_blog) web/plugs/auth.ex:57: PhoenixBlog.Plugs.Auth.authenticate_user/2
test/plugs/auth_test.exs:15: (test)
Notice that only the tests which hit the current_user doesn’t exist clause in authenticate_user fail.
defmodule PhoenixBlog.AuthTest do
use PhoenixBlog.ConnCase
alias PhoenixBlog.Plugs.Auth
setup %{conn: conn} do
conn =
conn
|> bypass_through(Rumbl.Router, :browser)
|> get("/")
{:ok, %{conn: conn}}
end
test "authenticate_user halts when no current_user exists", %{conn: conn} do
conn = Auth.authenticate_user(conn, [])
assert conn.halted
end
test "authenticate_user continues when the current_user exists", %{conn: conn} do
conn =
conn
|> assign(:current_user, %PhoenixBlog.User{})
|> Auth.authenticate_user([])
refute conn.halted
end
test "login puts the user into the session", %{conn: conn} do
login_conn =
conn
|> Auth.login(%PhoenixBlog.User{id: 123})
|> send_resp(:ok, "")
next_conn = get(login_conn, "/")
assert get_session(next_conn, :user_id) == 123
end
end
Auth plug:
defmodule PhoenixBlog.Plugs.Auth do
import Plug.Conn
import Comeonin.Bcrypt, only: [checkpw: 2, dummy_checkpw: 0]
def init(opts) do
Keyword.fetch!(opts, :repo)
end
def call(conn, repo) do
user_id = get_session(conn, :user_id)
cond do
user = conn.assigns[:current_user] ->
conn
user = user_id && repo.get(PhoenixBlog.User, user_id) ->
assign(conn, :current_user, user)
true ->
assign(conn, :current_user, nil)
end
end
def login(conn, user) do
conn
|> assign(:current_user, user)
|> put_session(:user_id, user.id)
|> configure_session(renew: true)
end
def logout(conn) do
configure_session(conn, drop: true)
end
def login_by_username_and_pass(conn, username, given_pass, opts) do
repo = Keyword.fetch!(opts, :repo)
user = repo.get_by(PhoenixBlog.User, username: username)
cond do
user && checkpw(given_pass, user.password_hash) ->
{:ok, login(conn, user)}
user ->
{:error, :unauthorized, conn}
true ->
dummy_checkpw()
{:error, :not_found, conn}
end
end
import Phoenix.Controller
alias PhoenixBlog.Router.Helpers
def authenticate_user(conn, _opts) do
if conn.assigns.current_user do
conn
else
conn
|> put_flash(:error, "You must be logged in to access that page")
|> redirect(to: Helpers.page_path(conn, :index))
|> halt()
end
end
end
Trending in Questions
I’m aware of 2 such projects, are there others?
git: GitHub - team-alembic/realworld: A fullstack Phoenix LiveView application with back...
New
I having some trouble figuring out if I have set myself too strict of standards for my production server. Currently I can handle 75% of r...
New
Hi everyone.
My team and I have been working on a fairly modest app based around video streaming and chat, but we’ve landed a customer t...
New
I really like the adapter patterns that ecto, nebulex, waffle, etc. use and would love find something similar for a key management servic...
New
Hello folks!
So at work, we are seeing some situations where we have to define some “fixed” strings that are used across the codebase in...
New
How Can I Optimise Compile Time Dependencies
I have been building an elixir application for about 2 years now. Many modules and files ha...
New
Hi,
we run different LLM models across a cluster, with each node loading a configurable subset. Model-specific queues let nodes consume ...
New
Other Trending Topics
A little off-topic, but I feel like people here have a good head on their shoulders.
I used to be quite good at making software. Was luc...
New
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New
I love Elixir. It’s one of 2 programming languages I’ve ever fallen in love with.
But I don’t use it anymore.
Serverless was the promis...
New
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #library
- #deployment
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #elixirconf
- #channels
- #exunit
- #discussion
- #code-sync
- #podcasts
- #javascript
- #onsite
- #dialyzer
- #docker
- #authentication
- #ai
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #blog-post
- #elixirconf-us
- #elixir-ls
- #phoenix_html
- #iex
- #graphql
- #genstage
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #elixirconf-eu
- #api
- #forms
- #security
- #performance










Showing Posts 1 to 7- Show Best Posts
- Show All (oldest first)
- Show All (newest first)
josevalim
I believe you need to call
conn = recycle(conn)after using the connection if you want to do another request with it.jswny
I’m not sure exactly where I would put that function, but I put it in the setup callback like so:
However that still did not fix my problem
I also tried putting the
recyclecall in each of the failing tests before I usedconnbut that did not work either. I’m not sure what to do.josevalim
It needs to be after get/2.
jswny
Now I get:
Which are the original problems that the book was trying to solve via
|> bypass_through(Rumbl.Router, :browser) |> get("/").jswny
Wow, I’m dumb
Turns out I forgot to change 
bypass_through(Rumbl.Router, :browser)tobypass_through(PhoenixBlog.Router, :browser)after I pasted the code from the book. Thanks Jose for your help and to @luke on Slack for talking the problem out with me and helping me fix itOleksiyNosov
For anybody who reads newer version of the book, please check that you bypass through right namespace:
RumblWebinstead ofRumbl.I had similar problem too
chriseyre
I am getting the same problem working through the >= 1.4 version of the book.
It starts failing on test “requires user authentication on all actions”